Disable nonmaindb interface #7905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7905 +/- ##
==========================================
- Coverage 89.70% 89.40% -0.30%
==========================================
Files 283 283
Lines 60519 60514 -5
Branches 7544 7541 -3
==========================================
- Hits 54286 54101 -185
- Misses 4079 4237 +158
- Partials 2154 2176 +22 |
naisila
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
This looks good to me, I vote for this one - removing the sql files and tests. Especially removing the sql files, I am neutral regarding the tests.
Important to note here that @eaydingol has run local tests with Assertions in the non-maindb paths to verify sanity.
We can also note in the description exactly which commits introduced those sql files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: The PR disables the non-main db related features.
The non-main db related features were introduced in #7203.